Conversation
since it's a JSON-style query request body it should be a POST not GET request
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
The verb is correct, and we use GET throughout the rest of this section too (see e.g. https://www.elastic.co/guide/en/elasticsearch/reference/current/_executing_searches.html) so this should remain as it is.
However, the following line does say that we "POST" the query which isn't right. I don't think we need to mention the HTTP verb in that sentence, so that's the fix I'd prefer.
Additionally, this change is opened against 6.1 instead of master because it came through the doc editor. Please could you rebase it against master and update the target branch to match?
|
@wr0ngc0degen any interest in changing this PR like @DaveCTurner suggested to get this in? Otherwise I think we should close this. |
|
Closing, @wr0ngc0degen if you would like to make the changes suggested here, please reopen as a PR against master. |
5 participants
since it's a JSON-style query request body it should be a POST not GET request
gradle check?